Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: content/public/browser/geolocation_delegate.h

Issue 2126893003: Geolocation cleanup: make GeolocationDelegate::OverrideSystemLocationProvider return unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wez@ comments; refactored GeolocationLocationArbitratorTest and TestingLocationArbitrator Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/geolocation_delegate.h
diff --git a/content/public/browser/geolocation_delegate.h b/content/public/browser/geolocation_delegate.h
index 2dc6047d12055564a8434c7efaa86ba61a413042..c09ba20cf9a8d9eaa2c11c3b5abcbd1688cd4d79 100644
--- a/content/public/browser/geolocation_delegate.h
+++ b/content/public/browser/geolocation_delegate.h
@@ -20,17 +20,17 @@ class CONTENT_EXPORT GeolocationDelegate {
// Returns true if the location API should use network-based location
// approximation in addition to the system provider, if any.
virtual bool UseNetworkLocationProviders();
- // Creates a new AccessTokenStore for geolocation. May return nullptr.
+
+ // Creates a new AccessTokenStore for geolocation. May return nullptr.
// TODO(mcasas): consider changing it return type to std::unique_ptr<> to
// clarify ownership, https://crbug.com/623114.
virtual AccessTokenStore* CreateAccessTokenStore();
- // Allows an embedder to return its own LocationProvider implementation.
+
+ // Allows an embedder to return its own LocationProvider implementation.
// Return nullptr to use the default one for the platform to be created.
- // Caller takes ownership of the returned LocationProvider. FYI: Used by an
- // external project; please don't remove. Contact Viatcheslav Ostapenko at
- // sl.ostapenko@samsung.com for more information.
- // TODO(mcasas): return std::unique_ptr<> instead, https://crbug.com/623132.
- virtual LocationProvider* OverrideSystemLocationProvider();
+ // FYI: Used by an external project; please don't remove. Contact Viatcheslav
+ // Ostapenko at sl.ostapenko@samsung.com for more information.
+ virtual std::unique_ptr<LocationProvider> OverrideSystemLocationProvider();
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698