Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: content/public/browser/geolocation_delegate.h

Issue 2126893003: Geolocation cleanup: make GeolocationDelegate::OverrideSystemLocationProvider return unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/geolocation_delegate.h
diff --git a/content/public/browser/geolocation_delegate.h b/content/public/browser/geolocation_delegate.h
index 2dc6047d12055564a8434c7efaa86ba61a413042..81148416bfefdd50deb12eb142b44dad0f7b4bdc 100644
--- a/content/public/browser/geolocation_delegate.h
+++ b/content/public/browser/geolocation_delegate.h
@@ -29,8 +29,7 @@ class CONTENT_EXPORT GeolocationDelegate {
// Caller takes ownership of the returned LocationProvider. FYI: Used by an
Wez 2016/07/07 18:51:39 nit: No need for the ownership comment now.
mcasas 2016/07/07 19:07:09 Done.
// external project; please don't remove. Contact Viatcheslav Ostapenko at
// sl.ostapenko@samsung.com for more information.
- // TODO(mcasas): return std::unique_ptr<> instead, https://crbug.com/623132.
- virtual LocationProvider* OverrideSystemLocationProvider();
+ virtual std::unique_ptr<LocationProvider> OverrideSystemLocationProvider();
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698