content/browser/geolocation/location_arbitrator_impl.cc - Issue 2126893003: Geolocation cleanup: make GeolocationDelegate::OverrideSystemLocationProvider return unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/location_arbitrator_impl.cc

Issue 2126893003: Geolocation cleanup: make GeolocationDelegate::OverrideSystemLocationProvider return unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wez@ nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/location_arbitrator_impl.h ('k') | content/browser/geolocation/location_arbitrator_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/location_arbitrator_impl.cc

diff --git a/content/browser/geolocation/location_arbitrator_impl.cc b/content/browser/geolocation/location_arbitrator_impl.cc

index 372951ef51f23deb91c9be206f73a79cc239ef6c..a5c87eaf76e6187ea7164bd2954da23a04058fae 100644

--- a/content/browser/geolocation/location_arbitrator_impl.cc

+++ b/content/browser/geolocation/location_arbitrator_impl.cc

@@ -123,7 +123,7 @@ void LocationArbitratorImpl::RegisterProvider(

void LocationArbitratorImpl::RegisterSystemProvider() {

std::unique_ptr<LocationProvider> provider =

- base::WrapUnique(delegate_->OverrideSystemLocationProvider());

+ delegate_->OverrideSystemLocationProvider();

if (!provider)

provider = NewSystemLocationProvider();

RegisterProvider(std::move(provider));