Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2126873005:
[ash-md] Doesn't recreate a rounded rect mask for overview windows (Closed)
|
Created:
4 years, 5 months ago by varkha Modified:
4 years, 5 months ago Reviewers:
Ian Vollick CC:
chromium-reviews, sadrul, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ash-md] Doesn't recreate a rounded rect mask for overview windows
This doesn't yet fix the bug but stops recreating mask layers.
BUG=624431
Committed: https://crrev.com/662bc7423311359bc9769dcf1d709a0fa6c8dba5
Cr-Commit-Position: refs/heads/master@{#405070}
Patch Set 1 : [ash-md] Doesn't recreate a rounded rect mask for overview windows #Patch Set 2 : [ash-md] Doesn't recreate a rounded rect mask for overview windows (rebased) #Patch Set 3 : [ash-md] Doesn't recreate a rounded rect mask for overview windows (test) #Patch Set 4 : [ash-md] Doesn't recreate a rounded rect mask for overview windows (rebased) #
Messages
Total messages: 45 (26 generated)
varkha@chromium.org changed reviewers: + vollick@chromium.org
vollick@, does this change make sense to you?
Patchset #1 (id:1) has been deleted
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
On 2016/07/07 at 23:15:45, commit-bot wrote: > Dry run: Try jobs failed on following builders: > mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Yep, this makes lots of sense. Is it possible to write a test to check the mask layer updates?
On 2016/07/11 17:17:52, vollick wrote: > On 2016/07/07 at 23:15:45, commit-bot wrote: > > Dry run: Try jobs failed on following builders: > > mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no > build URL) > > Yep, this makes lots of sense. Is it possible to write a test to check the mask > layer updates? Added a unit test. Checked that this new test fails if either of the code blocks added in layer.cc is missing.
On 2016/07/11 at 18:22:55, varkha wrote: > On 2016/07/11 17:17:52, vollick wrote: > > On 2016/07/07 at 23:15:45, commit-bot wrote: > > > Dry run: Try jobs failed on following builders: > > > mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no > > build URL) > > > > Yep, this makes lots of sense. Is it possible to write a test to check the mask > > layer updates? > > Added a unit test. Checked that this new test fails if either of the code blocks added in layer.cc is missing. lgtm.
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
Patchset #4 (id:100001) has been deleted
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by varkha@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org Link to the patchset: https://codereview.chromium.org/2126873005/#ps120001 (title: "[ash-md] Doesn't recreate a rounded rect mask for overview windows (rebased)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:120001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Doesn't recreate a rounded rect mask for overview windows This doesn't yet fix the bug but stops recreating mask layers. BUG=624431 ========== to ========== [ash-md] Doesn't recreate a rounded rect mask for overview windows This doesn't yet fix the bug but stops recreating mask layers. BUG=624431 Committed: https://crrev.com/662bc7423311359bc9769dcf1d709a0fa6c8dba5 Cr-Commit-Position: refs/heads/master@{#405070} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/662bc7423311359bc9769dcf1d709a0fa6c8dba5 Cr-Commit-Position: refs/heads/master@{#405070} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
