Change WebBluetooth chooser title to "pair with"

This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452
Committed: https://crrev.com/6d9f773baa347e4cfd0eef0b7a5dc5edf7fa6ed0
Cr-Commit-Position: refs/heads/master@{#405370}

[juncai, 2016-07-07 00:22:51]

Description was changed from

==========
This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452
==========

to

==========
This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452
==========

[juncai, 2016-07-13 17:52:41]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 17:53:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-07-13 17:57:10]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org, scheib@chromium.org

[juncai, 2016-07-13 17:57:10]

reillyg@chromium.org: Please review changes in
//chrome/browser/chooser_controller/
//chrome/browser/usb/

scheib@chromium.org: Please review changes in
//chrome/browser/ui/bluetooth/

[scheib, 2016-07-13 18:14:07]

Reilly's verbal feedback is good, I'll take another look after that. Here's one
tip though:

https://codereview.chromium.org/2126873003/diff/20001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2126873003/diff/20001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:37:
std::pair<base::string16, bool> title_prefix = GetTitlePrefix();
BTW, if you were using a tuple to be returned you can make the arguments
returned much easier to understand with std::tie
http://devdocs.io/cpp/utility/tuple/tie
See line: "std::tie(iter, inserted) = set_of_s.insert(value);"

[commit-bot: I haz the power, 2016-07-13 18:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:38:53]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-13 19:50:00]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:51:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-07-13 19:54:02]

Made some changes. Please take a look again.

[Reilly Grant (use Gerrit), 2016-07-13 20:40:08]

lgtm with one nit about constness.

https://codereview.chromium.org/2126873003/diff/40001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2126873003/diff/40001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:89: int
title_string_id_extension_;
These three can all be const:

content::RenderFrameHost* const owning_frame_;
const int title_string_id_origin_;
const int title_string_id_extension_;

[scheib, 2016-07-13 20:43:46]

Strings LGTM

[commit-bot: I haz the power, 2016-07-13 20:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:57:24]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-13 23:02:43]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[juncai, 2016-07-13 23:03:26]

https://codereview.chromium.org/2126873003/diff/40001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2126873003/diff/40001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:89: int
title_string_id_extension_;
On 2016/07/13 20:40:08, Reilly Grant wrote:
> These three can all be const:
> 
> content::RenderFrameHost* const owning_frame_;
> const int title_string_id_origin_;
> const int title_string_id_extension_;

Done.

[commit-bot: I haz the power, 2016-07-13 23:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 00:38:56]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-14 00:40:27]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-07-14 00:40:28]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2126873003/#ps60001
(title: "address comment")

[commit-bot: I haz the power, 2016-07-14 00:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:47:07]

Description was changed from

==========
This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452
==========

to

==========
This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452
==========

[commit-bot: I haz the power, 2016-07-14 00:47:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 00:47:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 00:48:13]

Description was changed from

==========
This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452
==========

to

==========
This is part 1 of matching WebBluetooth chooser views to mocks.

This CL changes the WebBluetooth chooser title from "connect to"
to "pair with".

BUG=583452

Committed: https://crrev.com/6d9f773baa347e4cfd0eef0b7a5dc5edf7fa6ed0
Cr-Commit-Position: refs/heads/master@{#405370}
==========

[commit-bot: I haz the power, 2016-07-14 00:48:15]

Patchset 4 (id:??) landed as
https://crrev.com/6d9f773baa347e4cfd0eef0b7a5dc5edf7fa6ed0
Cr-Commit-Position: refs/heads/master@{#405370}