Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2126843002: Reland of [gn] Switch more linux32 bots to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [gn] Switch more linux32 bots to gn (patchset #1 id:1 of https://codereview.chromium.org/2128493002/ ) Reason for revert: Should be fixed after https://codereview.chromium.org/2123223002/ Original issue's description: > Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ ) > > Reason for revert: > Breaks test isolation on shared library bot. > > Original issue's description: > > [gn] Switch more linux32 bots to gn > > > > This switches nosnap and shared library bots to gn. > > > > This also unsets external startup data if no snapshot is > > used. > > > > BUG=chromium:474921 > > NOTRY=true > > > > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a > > Cr-Commit-Position: refs/heads/master@{#37546} > > TBR=vogelheim@chromium.org,jochen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194 > Cr-Commit-Position: refs/heads/master@{#37548} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/d3413fa2daec9087b9f75f8429d572211deb5b66 Cr-Commit-Position: refs/heads/master@{#37558}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M gni/v8.gni View 1 1 chunk +7 lines, -1 line 0 comments Download
M infra/mb/mb_config.pyl View 1 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Achenbach
Created Reland of [gn] Switch more linux32 bots to gn
4 years, 5 months ago (2016-07-06 15:09:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126843002/1
4 years, 5 months ago (2016-07-06 15:09:10 UTC) #3
commit-bot: I haz the power
Failed to apply patch for infra/mb/mb_config.pyl: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-07-06 15:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126843002/70001
4 years, 5 months ago (2016-07-06 15:14:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 5 months ago (2016-07-06 15:14:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 15:17:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3413fa2daec9087b9f75f8429d572211deb5b66
Cr-Commit-Position: refs/heads/master@{#37558}

Powered by Google App Engine
This is Rietveld 408576698