Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2126793004: [CQ] Make gyp bot a blocking bot (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[CQ] Make gyp bot a blocking bot BUG=chromium:474921 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org, tandrii@chromium.org Committed: https://crrev.com/312d0149afda1982313bd8b47a2859e437538ac2 Cr-Commit-Position: refs/heads/master@{#37593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M infra/config/cq.cfg View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL
4 years, 5 months ago (2016-07-07 14:22:54 UTC) #3
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-07 14:34:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126793004/1
4 years, 5 months ago (2016-07-07 17:32:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 17:34:54 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 17:35:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/312d0149afda1982313bd8b47a2859e437538ac2
Cr-Commit-Position: refs/heads/master@{#37593}

Powered by Google App Engine
This is Rietveld 408576698