Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3467)

Unified Diff: extensions/renderer/console.cc

Issue 2126763002: Remove the prototype from all V8 functions that aren't constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/console.cc
diff --git a/extensions/renderer/console.cc b/extensions/renderer/console.cc
index f1b0ab598c610a40392508dd3970a57a6ce1bdcf..6b24c325c37c8e4bf41a48655f508e76d6a30d72 100644
--- a/extensions/renderer/console.cc
+++ b/extensions/renderer/console.cc
@@ -73,6 +73,7 @@ void BindLogMethod(v8::Isolate* isolate,
isolate,
&BoundLogMethodCallback,
v8::External::New(isolate, reinterpret_cast<void*>(log_method)));
+ tmpl->RemovePrototype();
v8::Local<v8::Function> function;
if (!tmpl->GetFunction(isolate->GetCurrentContext()).ToLocal(&function)) {
LOG(FATAL) << "Could not create log function \"" << name << "\"";
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698