Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2126753003: `about:blank` is not mixed content. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

`about:blank` is not mixed content. The refactoring in [1] broke our handling of `about:blank` by moving from `SecurityOrigin::isSecure(url)` to `SecurityOrigin::create(url)`. The latter treats contextually-bound URLs like `about:blank` as unique security origins, which I completely missed when writing tests. This patch corrects the error, and adds a unit test that I should have added a long time ago. :) [1]: https://chromium.googlesource.com/chromium/src/+/130ee686fa00b617bfc001ceb3bb49782da2cb4e BUG=624275 R=yoav@yoav.ws Review-Url: https://codereview.chromium.org/2123463002 Cr-Commit-Position: refs/heads/master@{#403655} (cherry picked from commit c6a3b5007b8aa2dbe513411b030032fef42b5b66) Committed: https://chromium.googlesource.com/chromium/src/+/0d2188b5c55d4ad2014b93682f5d1ace3008846b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Mike West
Committed patchset #1 (id:1) manually as 0d2188b5c55d4ad2014b93682f5d1ace3008846b.
4 years, 5 months ago (2016-07-06 10:57:31 UTC) #2
Yoav Weiss
4 years, 5 months ago (2016-07-06 10:59:25 UTC) #3
Message was sent while issue was closed.
On 2016/07/06 10:57:31, Mike West wrote:
> Committed patchset #1 (id:1) manually as
> 0d2188b5c55d4ad2014b93682f5d1ace3008846b.

LGTM

Powered by Google App Engine
This is Rietveld 408576698