third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2126733002: Make ScreenWakeLock ContextLifecycleObserver instead of LocalFrameLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2126733002: Make ScreenWakeLock ContextLifecycleObserver instead of LocalFrameLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 68290988d0e60bcbfdc241d3de062bb1099d008b..a17b7ea7c6c6e544609cb159d479cd66a4979218 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1488,8 +1488,6 @@ void WebLocalFrameImpl::setCoreFrame(LocalFrame* frame)

PermissionController::provideTo(*m_frame, m_client ? m_client->permissionClient() : nullptr);

if (RuntimeEnabledFeatures::webVREnabled())

VRController::provideTo(*m_frame, m_client ? m_client->serviceRegistry() : nullptr);

- if (RuntimeEnabledFeatures::wakeLockEnabled())

alogvinov 2016/07/06 08:42:17 Sorry I may have missed something, but why is this

alogvinov 2016/07/06 08:50:06 I see now, it is moved to ScreenWakeLock.

- ScreenWakeLock::provideTo(*m_frame, m_client ? m_client->serviceRegistry(): nullptr);

if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())

provideAudioOutputDeviceClientTo(*m_frame, AudioOutputDeviceClientImpl::create());

if (RuntimeEnabledFeatures::installedAppEnabled())

« content/browser/wake_lock/wake_lock_browsertest.cc ('K') | « third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp ('k') | no next file » | no next file with comments »