content/browser/wake_lock/wake_lock_browsertest.cc - Issue 2126733002: Make ScreenWakeLock ContextLifecycleObserver instead of LocalFrameLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/wake_lock/wake_lock_browsertest.cc

Issue 2126733002: Make ScreenWakeLock ContextLifecycleObserver instead of LocalFrameLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/wake_lock/wake_lock_browsertest.cc

diff --git a/content/browser/wake_lock/wake_lock_browsertest.cc b/content/browser/wake_lock/wake_lock_browsertest.cc

index 59e3ab71e1c0e168d3a7543725beafdf5517eee5..483d13c56f8ae266ce618ae604c558cdb0e41e41 100644

--- a/content/browser/wake_lock/wake_lock_browsertest.cc

+++ b/content/browser/wake_lock/wake_lock_browsertest.cc

@@ -266,7 +266,7 @@ IN_PROC_BROWSER_TEST_F(WakeLockTest, UnlockAfterReload) {

ScreenWakeLockInMainFrame();

shell()->Reload();

- WaitForLoadStop(GetWebContents());

+ WaitForPossibleUpdate();

// Screen wake lock should be released after reload.

EXPECT_FALSE(HasWakeLock());

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')