Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 212673002: CSS Transforms: Implement perspective-origin (Closed)

Created:
6 years, 9 months ago by dstockwell
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers, eseidel, esprehn, abarth-chromium, ojan, Julien - ping for review
Visibility:
Public.

Description

CSS Transforms: Implement perspective-origin Implements perspective-origin as defined in CSS Transforms[1]. Behavior is similar to -webkit-perspective-origin, however perspective-origin is not a shorthand. New parsing and serialization (mostly matching Gecko) has been introduced. The animation system is modified to avoid running animations and transitions on both the prefixed and unprefixed variants at the same time. Internally, animations are mapped to the unprefixed variant. As animations operate directly on the RenderStyle storage the result of specifying an animation on either -webkit-perspective-origin or perspective-origin is the same. However, support for independent animation/transition of -webkit-perspective-origin-* is removed. The X and Y coordinates now always transition together. Note, this property and changes in behavior are guarded by the CSSTransformsUnprefixed runtime feature (enabled only for testing). [1] http://www.w3.org/TR/css3-transforms/ BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170547

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -31 lines) Patch
M LayoutTests/animations/interpolation/perspective-origin-interpolation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/perspective-origin-interpolation-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
A + LayoutTests/animations/interpolation/webkit-perspective-origin-interpolation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/animations/interpolation/webkit-perspective-origin-interpolation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/transforms/perspective-origin-parsing.html View 1 chunk +47 lines, -0 lines 0 comments Download
A + LayoutTests/transitions/unprefixed-perspective-origin.html View 2 chunks +7 lines, -4 lines 0 comments Download
A LayoutTests/transitions/unprefixed-perspective-origin-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 4 chunks +8 lines, -3 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 chunks +56 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dstockwell
Depends on: https://codereview.chromium.org/212483003/
6 years, 9 months ago (2014-03-26 11:14:28 UTC) #1
eseidel
lgtm.
6 years, 9 months ago (2014-03-26 15:35:35 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-01 10:08:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212673002/130001
6 years, 8 months ago (2014-04-01 10:08:34 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 11:13:33 UTC) #5
Message was sent while issue was closed.
Change committed as 170547

Powered by Google App Engine
This is Rietveld 408576698