components/test/data/password_manager/login_db_v16.sql - Issue 2126713006: Refactor LoginDatabase migration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/test/data/password_manager/login_db_v16.sql

Issue 2126713006: Refactor LoginDatabase migration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/password_manager/core/browser/sql_table_builder_unittest.cc ('k') | components/test/data/password_manager/login_db_v17.sql » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 PRAGMA foreign_keys=OFF;	1 PRAGMA foreign_keys=OFF;

2 BEGIN TRANSACTION;	2 BEGIN TRANSACTION;

3 CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR );	3 CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR );

4 INSERT INTO "meta" VALUES('last_compatible_version','14');	4 INSERT INTO "meta" VALUES('last_compatible_version','14');

5 INSERT INTO "meta" VALUES('version','15');	5 INSERT INTO "meta" VALUES('version','16');

6 CREATE TABLE logins (	6 CREATE TABLE logins (

7 origin_url VARCHAR NOT NULL,	7 origin_url VARCHAR NOT NULL,

8 action_url VARCHAR,	8 action_url VARCHAR,

9 username_element VARCHAR,	9 username_element VARCHAR,

10 username_value VARCHAR,	10 username_value VARCHAR,

11 password_element VARCHAR,	11 password_element VARCHAR,

12 password_value BLOB,	12 password_value BLOB,

13 submit_element VARCHAR,	13 submit_element VARCHAR,

14 signon_realm VARCHAR NOT NULL,	14 signon_realm VARCHAR NOT NULL,

15 ssl_valid INTEGER NOT NULL,	15 ssl_valid INTEGER NOT NULL,

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 );	80 );

81 CREATE INDEX logins_signon ON logins (signon_realm);	81 CREATE INDEX logins_signon ON logins (signon_realm);

82 CREATE TABLE stats (	82 CREATE TABLE stats (

83 origin_domain VARCHAR NOT NULL,	83 origin_domain VARCHAR NOT NULL,

84 username_value VARCHAR,	84 username_value VARCHAR,

85 dismissal_count INTEGER,	85 dismissal_count INTEGER,

86 update_time INTEGER NOT NULL,	86 update_time INTEGER NOT NULL,

87 UNIQUE(origin_domain, username_value));	87 UNIQUE(origin_domain, username_value));

88 CREATE INDEX stats_origin ON stats(origin_domain);	88 CREATE INDEX stats_origin ON stats(origin_domain);

89 COMMIT;	89 COMMIT;

OLD	NEW