third_party/WebKit/Source/core/css/cssom/CSSVariableReferenceValue.idl - Issue 2126713002: [Typed-OM] Add CSSVariableReferenceValue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/CSSVariableReferenceValue.idl

Issue 2126713002: [Typed-OM] Add CSSVariableReferenceValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix the layout test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 [

	2 Constructor(),
	meade_UTC10 2016/07/07 05:30:30 Remove this. Remove this. anthonyhkf 2016/07/08 00:17:17 Done. Show quoted text On 2016/07/07 05:30:30, Eddy wrote: > Remove this. Done.
	3 Constructor(DOMString variable),

	4 Exposed=(Window,PaintWorklet),

	5 RuntimeEnabled=CSSTypedOM,

	6 ImplementedAs=CSSStyleVariableReferenceValue
	Timothy Loh 2016/07/07 05:40:26 OK for now, although this is a bit confusing. Mayb OK for now, although this is a bit confusing. Maybe we should have a TODO to rename things. meade_UTC10 2016/07/07 05:49:57 Do you have an idea for better naming? I'm at a bi Show quoted text On 2016/07/07 05:40:26, Timothy Loh wrote: > OK for now, although this is a bit confusing. Maybe we should have a TODO to > rename things. Do you have an idea for better naming? I'm at a bit of a loss (and CSSVariableReferenceValue was taken) anthonyhkf 2016/07/08 00:17:17 Acknowledged. Show quoted text On 2016/07/07 05:40:26, Timothy Loh wrote: > OK for now, although this is a bit confusing. Maybe we should have a TODO to > rename things. Acknowledged.
	7 // TODO(anthonyhkf): add fallback: Constructor(DOMString variable, CSSTokenStre amValue fallback)

	8 ] interface CSSVariableReferenceValue {

	9 readonly attribute DOMString variable;

	10 // TODO(anthonyhkf): add fallback: readonly attribute CSSTokenStreamValue fallb ack;

	11 };

OLD	NEW