[Typed-OM] Add CSSVariableReferenceValue

third_party/WebKit/Source/core/css/cssom/CSSStyleVariableReferenceValue.h

+#ifndef CSSStyleVariableReferenceValue_h

[Timothy Loh, 2016/07/07 05:40:26]

There's a 3-line license header to add on new files, see blink.style/guide

[anthonyhkf, 2016/07/08 00:17:17]

Done.

+#define CSSStyleVariableReferenceValue_h
+
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/CSSPropertyNames.h"
+#include "core/CoreExport.h"
+#include "core/css/CSSValue.h"
+
+namespace blink {
+
+class CORE_EXPORT CSSStyleVariableReferenceValue final : public GarbageCollectedFinalized<CSSStyleVariableReferenceValue>, public ScriptWrappable {
+    WTF_MAKE_NONCOPYABLE(CSSStyleVariableReferenceValue);
+    DEFINE_WRAPPERTYPEINFO();
+public:
+    virtual ~CSSStyleVariableReferenceValue() { }
+
+    static CSSStyleVariableReferenceValue* create()
+    {
+        return new CSSStyleVariableReferenceValue();
+    }
+
+    // TODO(anthonyhkf): add fallback: create(variable, fallback)
+    static CSSStyleVariableReferenceValue* create(const String& variable)
+    {
+        return new CSSStyleVariableReferenceValue(variable);
+    }
+
+    DEFINE_INLINE_TRACE() { }
+
+    String variable() const { return m_variable; }

[Timothy Loh, 2016/07/07 05:40:26]

const String& is probably more common (maybe avoids some ref churn too)

[anthonyhkf, 2016/07/08 00:17:17]

Done.

+
+protected:
+    CSSStyleVariableReferenceValue() { }

[meade_UTC10, 2016/07/07 05:30:30]

We shouldn't have this empty constructor - m_variable won't be initialised in
this case. You can also remove the empty create method and the empty constructor
in the IDL.

[anthonyhkf, 2016/07/08 00:17:17]

Done.

+
+    CSSStyleVariableReferenceValue(String variable)
+    {

[Timothy Loh, 2016/07/07 05:40:26]

Use an initializer list here, e.g.

CSSStyl..(..)
: m_variable(variable)
{ }

[anthonyhkf, 2016/07/08 00:17:17]

Done.

+        m_variable = variable;
+    }
+
+    String m_variable;
+
+};
+
+}

[Timothy Loh, 2016/07/07 05:40:26]

prevalent style is to write

} // namespace blink

#endif // BlaBlaBla_h

[anthonyhkf, 2016/07/08 00:17:17]

Done.

+
+#endif