third_party/WebKit/Source/core/css/cssom/CSSVariableReferenceValue.idl - Issue 2126713002: [Typed-OM] Add CSSVariableReferenceValue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/CSSVariableReferenceValue.idl

Issue 2126713002: [Typed-OM] Add CSSVariableReferenceValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 [

	2 Exposed=(Window,PaintWorklet),

	3 RuntimeEnabled=CSSTypedOM,

	4 ImplementedAs=CSSStyleVariableReferenceValue,

	5 Constructor(),

	6 Constructor(DOMString variable)
	meade_UTC10 2016/07/06 05:40:12 In the other files, we've always put the construct In the other files, we've always put the constructor first. Please re-order these items so the constructors are first.
	7 // TODO: add fallback: Constructor(DOMString variable, DOMString fallback)
	meade_UTC10 2016/07/06 05:40:12 Should be TODO(anthonyhsk): ... Should be TODO(anthonyhsk): ...
	8 ] interface CSSVariableReferenceValue {

	9 attribute DOMString variable;
	meade_UTC10 2016/07/06 05:40:12 Let's make this readonly. readonly attribute DOMS Let's make this readonly. readonly attribute DOMString variable;
	10 // TODO: add fallback: attribute CSSTokenStreamValue fallback;

	11 };

OLD	NEW