[Typed-OM] Add CSSVariableReferenceValue

third_party/WebKit/Source/core/css/cssom/CSSStyleVariableReferenceValue.h

+#ifndef CSSStyleVariableReferenceValue_h
+#define CSSStyleVariableReferenceValue_h
+
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/CSSPropertyNames.h"
+#include "core/CoreExport.h"
+#include "core/css/CSSValue.h"
+
+namespace blink {
+
+// TODO: change the data type of fallback as in the draft

[meade_UTC10, 2016/07/06 05:40:11]

You don't need to have two TODO's, just the second one is fine. Please delete
this line.

[anthonyhkf, 2016/07/08 00:17:17]

Done.

+
+class CORE_EXPORT CSSStyleVariableReferenceValue : public GarbageCollectedFinalized<CSSStyleVariableReferenceValue>, public ScriptWrappable {

[meade_UTC10, 2016/07/06 05:40:11]

Please make this class final.

+    DEFINE_WRAPPERTYPEINFO();

[meade_UTC10, 2016/07/06 05:40:12]

This class shouldn't be copyable. Please add the macro

WTF_MAKE_NONCOPYABLE(CSSStyleVariableReferenceValue);

+public:
+    virtual ~CSSStyleVariableReferenceValue() { }
+
+    static CSSStyleVariableReferenceValue* create()
+    {
+        return new CSSStyleVariableReferenceValue();
+    }
+
+    // TODO: add fallback: create(variable, fallback)

[meade_UTC10, 2016/07/06 05:40:12]

Make this

// TODO(anthonyhkf): Add fallback: create(variable, fallback).

+    static CSSStyleVariableReferenceValue* create(const String& variable)
+    {
+        return new CSSStyleVariableReferenceValue(variable);
+    }
+
+    DEFINE_INLINE_TRACE() { }
+
+    void setVariable(String variable) { m_variable = variable; }

[meade_UTC10, 2016/07/06 05:40:11]

StyleValues should be read-only - please remove this method and change the
corresponding IDL also be readonly.

+
+    String variable() const { return m_variable; }
+
+protected:
+    CSSStyleVariableReferenceValue() { }
+
+    CSSStyleVariableReferenceValue(String variable)
+    {
+        m_variable = variable;
+    }
+
+    String m_variable;
+
+};
+
+}
+
+#endif