Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2126703002: [mojo-edk] Post a task to process local messages. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Post a task to process local messages. This ensures the local message queue is _always_ processed, instead of relying on the side effect of certain functions such as SendMessage. BUG=612500 Committed: https://crrev.com/a18ca6b383554d7806787028c0961858e90bb086 Cr-Commit-Position: refs/heads/master@{#404281}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M mojo/edk/system/node_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 1 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Anand Mistry (off Chromium)
Highly speculative, wildly accusational and completely unsubstantiated fix for sync call renderer hangs. Approve at ...
4 years, 5 months ago (2016-07-06 05:14:51 UTC) #2
Ken Rockot(use gerrit already)
On 2016/07/06 at 05:14:51, amistry wrote: > Highly speculative, wildly accusational and completely unsubstantiated fix ...
4 years, 5 months ago (2016-07-06 20:03:08 UTC) #3
Anand Mistry (off Chromium)
On 2016/07/06 20:03:08, Ken Rockot wrote: > On 2016/07/06 at 05:14:51, amistry wrote: > > ...
4 years, 5 months ago (2016-07-07 00:01:41 UTC) #4
Ken Rockot(use gerrit already)
On 2016/07/07 at 00:01:41, amistry wrote: > On 2016/07/06 20:03:08, Ken Rockot wrote: > > ...
4 years, 5 months ago (2016-07-07 04:57:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126703002/20001
4 years, 5 months ago (2016-07-07 06:58:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/32373)
4 years, 5 months ago (2016-07-07 07:03:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126703002/20001
4 years, 5 months ago (2016-07-08 00:33:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 00:47:47 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 00:50:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a18ca6b383554d7806787028c0961858e90bb086
Cr-Commit-Position: refs/heads/master@{#404281}

Powered by Google App Engine
This is Rietveld 408576698