Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2126693003: [d8] Fix Shell::Stringify when exceptions are thrown. (Closed)

Created:
4 years, 5 months ago by Jakob Kummerow
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Fix Shell::Stringify when exceptions are thrown. BUG=v8:5105 Committed: https://crrev.com/e0348dc78338aa4b0ae60771cba3017d23787641 Cr-Commit-Position: refs/heads/master@{#37553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/d8.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jakob Kummerow
PTAL. Clearly the "result.IsEmpty()" check should happen before .ToLocalChecked(). Verified in an interactive d8 session; ...
4 years, 5 months ago (2016-07-06 13:37:20 UTC) #2
Yang
On 2016/07/06 13:37:20, Jakob wrote: > PTAL. Clearly the "result.IsEmpty()" check should happen before > ...
4 years, 5 months ago (2016-07-06 13:38:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126693003/1
4 years, 5 months ago (2016-07-06 13:38:29 UTC) #5
Yang
On 2016/07/06 13:38:06, Yang wrote: > On 2016/07/06 13:37:20, Jakob wrote: > > PTAL. Clearly ...
4 years, 5 months ago (2016-07-06 13:38:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 14:00:52 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 14:00:55 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:02:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0348dc78338aa4b0ae60771cba3017d23787641
Cr-Commit-Position: refs/heads/master@{#37553}

Powered by Google App Engine
This is Rietveld 408576698