[turbofan] Set elements kind to holey if constructing array of possibly non-zero length.

[turbofan] Set elements kind to holey if constructing array of possibly non-zero length.

BUG=chromium:621147
Committed: https://crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e
Cr-Commit-Position: refs/heads/master@{#37543}

[Jarin, 2016-07-06 04:39:59]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org, verwaest@chromium.org

[Jarin, 2016-07-06 04:40:00]

Could you take a look, please?

https://codereview.chromium.org/2126623003/diff/1/src/compiler/js-create-lowe...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2126623003/diff/1/src/compiler/js-create-lowe...
src/compiler/js-create-lowering.cc:476: if
(NodeProperties::GetType(length)->Max() > 0) {
Not sure whether we should thread through the type cache just to be able to say
!GetType(length)->Is(cache_.kSingletonZero). WDYT?

[Jarin, 2016-07-06 07:17:33]

Description was changed from

==========
[turbofan] Set elements kind to holey if constructing array of possibly non-zero
length.

BUG=chromium:621147
==========

to

==========
[turbofan] Set elements kind to holey if constructing array of possibly non-zero
length.

BUG=chromium:621147
==========

[Jarin, 2016-07-06 07:17:33]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-07-06 07:36:52]

LGTM.

[Jarin, 2016-07-06 07:37:48]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-07-06 07:37:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-07-06 07:50:12]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2016-07-06 07:50:13]

https://codereview.chromium.org/2126623003/diff/1/test/mjsunit/compiler/regre...
File test/mjsunit/compiler/regress-621147.js (right):

https://codereview.chromium.org/2126623003/diff/1/test/mjsunit/compiler/regre...
test/mjsunit/compiler/regress-621147.js:1: // Copyright 2014 the V8 project
authors. All rights reserved.
2016

[Benedikt Meurer (Google), 2016-07-06 07:50:25]

On 2016/07/06 07:37:58, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Thx, lgtm.

[commit-bot: I haz the power, 2016-07-06 07:54:20]

Description was changed from

==========
[turbofan] Set elements kind to holey if constructing array of possibly non-zero
length.

BUG=chromium:621147
==========

to

==========
[turbofan] Set elements kind to holey if constructing array of possibly non-zero
length.

BUG=chromium:621147
==========

[commit-bot: I haz the power, 2016-07-06 07:54:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-06 07:55:44]

Description was changed from

==========
[turbofan] Set elements kind to holey if constructing array of possibly non-zero
length.

BUG=chromium:621147
==========

to

==========
[turbofan] Set elements kind to holey if constructing array of possibly non-zero
length.

BUG=chromium:621147

Committed: https://crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e
Cr-Commit-Position: refs/heads/master@{#37543}
==========

[commit-bot: I haz the power, 2016-07-06 07:55:45]

Patchset 1 (id:??) landed as
https://crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e
Cr-Commit-Position: refs/heads/master@{#37543}