Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2126623002: Roll ANGLE 474a08c..3820e9c (Closed)

Created:
4 years, 5 months ago by Geoff Lang
Modified:
4 years, 5 months ago
Reviewers:
Jamie Madill
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE 474a08c..3820e9c https://chromium.googlesource.com/angle/angle.git/+log/474a08c..3820e9c BUG=chromium:625363, 612205, chromium:616176, 407309 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel Committed: https://crrev.com/6f88ffc45920456f0840acf3299c0a5e24bdebc9 Cr-Commit-Position: refs/heads/master@{#403788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126623002/1
4 years, 5 months ago (2016-07-05 15:11:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 16:21:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6f88ffc45920456f0840acf3299c0a5e24bdebc9 Cr-Commit-Position: refs/heads/master@{#403788}
4 years, 5 months ago (2016-07-05 16:23:25 UTC) #5
lmilko
On 2016/07/05 16:23:25, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 5 months ago (2016-07-06 11:18:03 UTC) #6
James Cook
4 years, 5 months ago (2016-07-06 16:58:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2122233002/ by jamescook@chromium.org.

The reason for reverting is: Broke ARM chrome compile on chromeos:

chromeos-chrome-54.0.2789.0_rc-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/angle/src/image_util/loadimage_sse2.cpp:17:23:
fatal error: emmintrin.h: No such file or directory
chromeos-chrome-54.0.2789.0_rc-r1:  #include <emmintrin.h>

chromeos-chrome-54.0.2789.0_rc-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/angle/src/image_util/loadimage_sse2.cpp:17:23:
fatal error: emmintrin.h: No such file or directory
chromeos-chrome-54.0.2789.0_rc-r1:  #include <emmintrin.h>

NOTRY=true
NOTREECHECKS=true
.

Powered by Google App Engine
This is Rietveld 408576698