Chromium Code Reviews| Index: src/factory.cc |
| diff --git a/src/factory.cc b/src/factory.cc |
| index 4140159f9312ffb8ce5c83fa4a536997c99fd8cf..6d4adae1de19c761915c6790134945f75ea41f0b 100644 |
| --- a/src/factory.cc |
| +++ b/src/factory.cc |
| @@ -1647,19 +1647,28 @@ void Factory::NewJSArrayStorage(Handle<JSArray> array, |
| Handle<FixedArrayBase> elms; |
| ElementsKind elements_kind = array->GetElementsKind(); |
| if (IsFastDoubleElementsKind(elements_kind)) { |
| - if (mode == DONT_INITIALIZE_ARRAY_ELEMENTS) { |
| - elms = NewFixedDoubleArray(capacity); |
| - } else { |
| - DCHECK(mode == INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE); |
| - elms = NewFixedDoubleArrayWithHoles(capacity); |
| + switch (mode) { |
| + case DONT_INITIALIZE_ARRAY_ELEMENTS: |
| + elms = NewFixedDoubleArray(capacity); |
| + break; |
| + case INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE: |
| + elms = NewFixedDoubleArrayWithHoles(capacity); |
| + break; |
| + case INITIALIZE_ARRAY_ELEMENTS_WITH_UNDEFINED: |
| + UNREACHABLE(); |
|
Igor Sheludko
2016/07/11 15:37:10
break;
|
| } |
| } else { |
| DCHECK(IsFastSmiOrObjectElementsKind(elements_kind)); |
| - if (mode == DONT_INITIALIZE_ARRAY_ELEMENTS) { |
| - elms = NewUninitializedFixedArray(capacity); |
| - } else { |
| - DCHECK(mode == INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE); |
| - elms = NewFixedArrayWithHoles(capacity); |
| + switch (mode) { |
| + case DONT_INITIALIZE_ARRAY_ELEMENTS: |
| + elms = NewUninitializedFixedArray(capacity); |
| + break; |
| + case INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE: |
| + elms = NewFixedArrayWithHoles(capacity); |
| + break; |
| + case INITIALIZE_ARRAY_ELEMENTS_WITH_UNDEFINED: |
| + elms = NewFixedArray(capacity); |
| + break; |
| } |
| } |