making heap verification more aggressive

src/factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/factory.h"
 
 #include "src/allocation-site-scopes.h"
 #include "src/base/bits.h"
 #include "src/bootstrapper.h"
 #include "src/conversions.h"
@@ skipping 1627 matching lines @@
   if (capacity == 0) {
     array->set_length(Smi::FromInt(0));
     array->set_elements(*empty_fixed_array());
     return;
   }
 
   HandleScope inner_scope(isolate());
   Handle<FixedArrayBase> elms;
   ElementsKind elements_kind = array->GetElementsKind();
   if (IsFastDoubleElementsKind(elements_kind)) {
-    if (mode == DONT_INITIALIZE_ARRAY_ELEMENTS) {
-      elms = NewFixedDoubleArray(capacity);
-    } else {
-      DCHECK(mode == INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE);
-      elms = NewFixedDoubleArrayWithHoles(capacity);
+    switch (mode) {
+      case DONT_INITIALIZE_ARRAY_ELEMENTS:
+        elms = NewFixedDoubleArray(capacity);
+        break;
+      case INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE:
+        elms = NewFixedDoubleArrayWithHoles(capacity);
+        break;
+      default:

[ulan, 2016/07/08 06:19:40]

case INITIALIZE_ARRAY_ELEMENTS_WITH_UNDEFINED: UNREACHABLE();

With enums it is better to avoid the default case. That way the compiler can
give warnings if some case is missing.

[Camillo Bruni, 2016/07/11 11:46:38]

done.

+        UNREACHABLE();
     }
   } else {
     DCHECK(IsFastSmiOrObjectElementsKind(elements_kind));
-    if (mode == DONT_INITIALIZE_ARRAY_ELEMENTS) {
-      elms = NewUninitializedFixedArray(capacity);
-    } else {
-      DCHECK(mode == INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE);
-      elms = NewFixedArrayWithHoles(capacity);
+    switch (mode) {
+      case DONT_INITIALIZE_ARRAY_ELEMENTS:
+        elms = NewUninitializedFixedArray(capacity);
+        break;
+      case INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE:
+        elms = NewFixedArrayWithHoles(capacity);
+        break;
+      case INITIALIZE_ARRAY_ELEMENTS_WITH_UNDEFINED:
+        elms = NewFixedArray(capacity);

[Igor Sheludko, 2016/07/08 08:38:22]

I think it's better to have breaks even in the last cases.

[Camillo Bruni, 2016/07/11 11:46:38]

done.

     }
   }
 
   array->set_elements(*elms);
   array->set_length(Smi::FromInt(length));
 }
 
 
 Handle<JSGeneratorObject> Factory::NewJSGeneratorObject(
     Handle<JSFunction> function) {
@@ skipping 705 matching lines @@
 }
 
 
 Handle<Object> Factory::ToBoolean(bool value) {
   return value ? true_value() : false_value();
 }
 
 
 }  // namespace internal
 }  // namespace v8