Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2126603004: Change ASSERT to CHECK in DrawingBuffer::reset for investigation (Closed)

Created:
4 years, 5 months ago by Justin Novosad
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ASSERT to CHECK in DrawingBuffer::reset for investigation Changing this assert to a CHECK which will re-introduce crashes related to bug 542857, but will result in crash reports that will allow us to understand how the DrawingBuffer got into a bad state. CL to be reverted before next branch point. BUG=542857 TBR=kbr@chromium.org Committed: https://crrev.com/9cd13f726995393db68768a714049ea7650b9f86 Cr-Commit-Position: refs/heads/master@{#403824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126603004/1
4 years, 5 months ago (2016-07-05 20:12:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 21:28:45 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 21:28:48 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 21:30:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cd13f726995393db68768a714049ea7650b9f86
Cr-Commit-Position: refs/heads/master@{#403824}

Powered by Google App Engine
This is Rietveld 408576698