Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2126593002: Remove Object.observe UseCounter and deprecation warning (Closed)

Created:
4 years, 5 months ago by Rick Byers
Modified:
4 years, 5 months ago
Reviewers:
adamk
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Object.observe UseCounter and deprecation warning Object.observe is long gone, remove the unreachable counter to avoid confusion (since it references a long-gone milestone). BUG=162553 Committed: https://crrev.com/6bc726f327493247a01876b2d19dc960ce15e805 Cr-Commit-Position: refs/heads/master@{#404942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Rick Byers
adamk@ PTAL
4 years, 5 months ago (2016-07-05 13:53:15 UTC) #2
adamk
lgtm, thanks. This isn't the only dead usecounter from the v8 side, but I guess ...
4 years, 5 months ago (2016-07-12 17:19:40 UTC) #3
Rick Byers
On 2016/07/12 17:19:40, adamk wrote: > lgtm, thanks. This isn't the only dead usecounter from ...
4 years, 5 months ago (2016-07-13 00:28:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126593002/1
4 years, 5 months ago (2016-07-13 00:34:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:07:53 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:08:28 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:09:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bc726f327493247a01876b2d19dc960ce15e805
Cr-Commit-Position: refs/heads/master@{#404942}

Powered by Google App Engine
This is Rietveld 408576698