Reland: Use metadata when launching WebAPKs.

Reland: Use metadata when launching WebAPKs.

WebAPKs use WebappDataStorage to store the metadata too.
Some changes in the web app manifest, like themeColor,
orientation etc. don't request re-minting a WebAPK,
but will update the metadata in the SharedPreference
(WebappDataStorage). The metadata will be retrieved
and used for launching a WebAPK.

Registering a WebAPK will be in a following up CL.

BUG=624834
Committed: https://crrev.com/a3bc57c0fd8faf57f0fbd98d65913f47ab02917c
Cr-Commit-Position: refs/heads/master@{#403901}

[Xi Han, 2016-07-05 13:57:40]

hanxi@chromium.org changed reviewers:
+ dominickn@chromium.org

[Xi Han, 2016-07-05 13:57:40]

Hi Dominick, I wasn't able to reproduce the failures on
Android_tests(https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35147).
But I believed it was the first assertion in
WebappActivity#retrieveSplashScreenImage(WebappDataStorage storage) caused the
Android_Tests crashes. So I removed it. Anything else remains unchanged. PTAL,
thanks!

[dominickn, 2016-07-06 00:24:25]

FYI, asserts are only triggered on pre-L devices - anything after that ignores
them.

The assert you removed does look erroneously placed, because
retrieveSplashScreen is definitely invoked on the UI thread
(WebappDataStorage.getSplashScreenImage internally uses an AsyncTask to do
things in the background, so its invoker is in the UI thread)

lgtm

[Xi Han, 2016-07-06 02:33:35]

hanxi@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Xi Han, 2016-07-06 02:33:35]

Dminick: thank you for the explanation, I guess that is why I cannot reproduce
it on my testing device, which is M.

Yaron: I need owners review for WebApkActivity.java, could you please take a
look? Thanks!

[Xi Han, 2016-07-06 02:34:08]

Dominick: thank you for the explanation, I guess that is why I cannot reproduce
it on my testing device, which is M.

Yaron: I need owners review for WebApkActivity.java, could you please take a
look? Thanks!

[Yaron, 2016-07-06 13:18:48]

lgtm

In the future, please upload the original change as patchset 1 - that would make
the diff for the reland easier to spot

[Xi Han, 2016-07-06 13:19:56]

That is a good idea, will do next time!

[Xi Han, 2016-07-06 13:20:09]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2016-07-06 13:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 13:56:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-06 13:58:13]

Description was changed from

==========
Reland: Use metadata when launching WebAPKs.

WebAPKs use WebappDataStorage to store the metadata too.
Some changes in the web app manifest, like themeColor,
orientation etc. don't request re-minting a WebAPK,
but will update the metadata in the SharedPreference
(WebappDataStorage). The metadata will be retrieved
and used for launching a WebAPK.

Registering a WebAPK will be in a following up CL.

BUG=624834
==========

to

==========
Reland: Use metadata when launching WebAPKs.

WebAPKs use WebappDataStorage to store the metadata too.
Some changes in the web app manifest, like themeColor,
orientation etc. don't request re-minting a WebAPK,
but will update the metadata in the SharedPreference
(WebappDataStorage). The metadata will be retrieved
and used for launching a WebAPK.

Registering a WebAPK will be in a following up CL.

BUG=624834

Committed: https://crrev.com/a3bc57c0fd8faf57f0fbd98d65913f47ab02917c
Cr-Commit-Position: refs/heads/master@{#403901}
==========

[commit-bot: I haz the power, 2016-07-06 13:58:14]

Patchset 1 (id:??) landed as
https://crrev.com/a3bc57c0fd8faf57f0fbd98d65913f47ab02917c
Cr-Commit-Position: refs/heads/master@{#403901}