Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2126533002: V8: Switch x87 bots to swarming. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -153 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +11 lines, -1 line 3 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json View 2 chunks +159 lines, -146 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json View 6 chunks +73 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2126533002/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/2126533002/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1523 scripts/slave/recipe_modules/v8/builders.py:1523: 'os': 'Ubuntu-14.04', Using trusty will fix the referenced ...
4 years, 5 months ago (2016-07-05 12:03:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126533002/1
4 years, 5 months ago (2016-07-05 12:05:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/6120e3f63c5a012dddfa795d2ffb8b19e0aa3b16
4 years, 5 months ago (2016-07-05 12:08:57 UTC) #7
tandrii(chromium)
4 years, 5 months ago (2016-07-05 12:18:52 UTC) #8
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2126533002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/builders.py (right):

https://codereview.chromium.org/2126533002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/builders.py:1526: 'default_expiration': 2 * 60 *
60,
On 2016/07/05 12:03:40, Michael Achenbach wrote:
> Bot has long running tests, therefore higher timeouts. Lower prio as bot is
fyi.

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698