Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Issue 212653006: Add CSSUnknownRule.idl to |core_idl_files| (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Add CSSUnknownRule.idl to |core_idl_files| There's currently a comment in core.gypi that reads: """ We should probably add CSSUnknownRule.idl to this list, but it currently causes a compile error. """ Now that we've switched to Python (and proper IDL processing), this no longer causes a compile error, so I think we can switch it on. Changes: This adds CSSUnknownRule to the global constructors. This dates to April 2013: Introduce bindings.gyp https://codereview.chromium.org/14110002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170144

Patch Set 1 #

Patch Set 2 : Rebase tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Nils Barth (inactive)
Hi Adam, Just noticed I could fix a TODO in core.gypi. (Fixing the wonky inter-dependencies ...
6 years, 9 months ago (2014-03-27 02:37:02 UTC) #1
haraken
On 2014/03/27 02:37:02, Nils Barth wrote: > Hi Adam, > Just noticed I could fix ...
6 years, 9 months ago (2014-03-27 02:38:53 UTC) #2
haraken
On 2014/03/27 02:38:53, haraken wrote: > On 2014/03/27 02:37:02, Nils Barth wrote: > > Hi ...
6 years, 9 months ago (2014-03-27 02:40:26 UTC) #3
Nils Barth (inactive)
On 2014/03/27 02:38:53, haraken wrote: > You can ask a patch author of CSSUnknownRule? (off-line): ...
6 years, 9 months ago (2014-03-27 02:40:35 UTC) #4
abarth-chromium
Oh, great. LGTM CSSUnknownRule.idl used to be a really odd duck. I'm glad that it's ...
6 years, 9 months ago (2014-03-27 03:46:07 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-27 03:47:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/212653006/1
6 years, 9 months ago (2014-03-27 03:47:52 UTC) #7
Nils Barth (inactive)
On 2014/03/27 03:46:07, abarth wrote: > Oh, great. LGTM > > CSSUnknownRule.idl used to be ...
6 years, 9 months ago (2014-03-27 03:48:23 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 04:19:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-27 04:19:12 UTC) #10
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-27 05:11:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/212653006/20001
6 years, 9 months ago (2014-03-27 05:11:37 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 06:18:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 06:18:16 UTC) #14
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-27 06:23:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/212653006/20001
6 years, 9 months ago (2014-03-27 06:24:04 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 07:24:19 UTC) #17
Message was sent while issue was closed.
Change committed as 170144

Powered by Google App Engine
This is Rietveld 408576698