Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2126473002: Revert CSSMatrix classname to CSSMatrixTransformComponent (Closed)

Created:
4 years, 5 months ago by meade_UTC10
Modified:
4 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert CSSMatrix classname to CSSMatrixTransformComponent See also: https://developer.mozilla.org/en-US/docs/Web/API/CSSMatrix https://bugs.chromium.org/p/chromium/issues/detail?id=621945 WebkitCSSMatrix and MSCSSMatrix exist with a different API, and some libraries, including Adobe animations and the Closure library write code like window.CSSMatrix || window.WebKitCSSMatrix || window.MSCSSMatrix, which causes some websites to break (notably Google photos, some others I found were www.bahamas.com and www.australianexplorer.com). Adobe's animation library is versioned and while mostly served from adobe.com, is also served from other domains. Aside from breaking pages, it will be confusing for developers to have CSSMatrix and WebkitCSSMatrix/MSCSSMatrix have such different interfaces. We can choose a better name for this component after unbreaking people who run with experimental-web-platform-features on. BUG=621945 Committed: https://crrev.com/cb9092d095295e44f0d636886ba9404ed218609c Cr-Commit-Position: refs/heads/master@{#403852}

Patch Set 1 #

Patch Set 2 : Rename CSSMatrix -> CSSMatrixTransformComponent #

Patch Set 3 : Rename in build and tests #

Patch Set 4 : Update references in other idl files #

Patch Set 5 : Rename cssMatrix layout test as well #

Patch Set 6 : Update webexposed tests as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -157 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssMatrix.html View 1 2 3 4 1 chunk +0 lines, -80 lines 0 comments Download
A + third_party/WebKit/LayoutTests/typedcssom/cssMatrixTransformComponent.html View 1 2 3 4 3 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTransformValue.html View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSMatrix.idl View 1 1 chunk +0 lines, -37 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.idl View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-05 08:18:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126473002/80001
4 years, 5 months ago (2016-07-05 08:26:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/250134)
4 years, 5 months ago (2016-07-05 09:33:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126473002/100001
4 years, 5 months ago (2016-07-06 03:26:24 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-06 04:53:35 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 04:55:06 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cb9092d095295e44f0d636886ba9404ed218609c
Cr-Commit-Position: refs/heads/master@{#403852}

Powered by Google App Engine
This is Rietveld 408576698