Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Side by Side Diff: src/debug/mirrors.js

Issue 2126453002: [intrinsic] Drop the %_ValueOf intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix noi18n build (narf) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2012 the V8 project authors. All rights reserved. 1 // Copyright 2006-2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
11 var ErrorToString; 11 var ErrorToString;
12 var GlobalArray = global.Array; 12 var GlobalArray = global.Array;
13 var IsNaN = global.isNaN; 13 var IsNaN = global.isNaN;
14 var JSONStringify = global.JSON.stringify; 14 var JSONStringify = global.JSON.stringify;
15 var MakeError; 15 var MakeError;
16 var MapEntries; 16 var MapEntries;
17 var MapIteratorNext; 17 var MapIteratorNext;
18 var promiseStateSymbol = utils.ImportNow("promise_state_symbol"); 18 var promiseStateSymbol = utils.ImportNow("promise_state_symbol");
19 var promiseResultSymbol = utils.ImportNow("promise_result_symbol"); 19 var promiseResultSymbol = utils.ImportNow("promise_result_symbol");
20 var SetIteratorNext; 20 var SetIteratorNext;
21 var SetValues; 21 var SetValues;
22 var SymbolToString;
23 22
24 utils.Import(function(from) { 23 utils.Import(function(from) {
25 ErrorToString = from.ErrorToString; 24 ErrorToString = from.ErrorToString;
26 MakeError = from.MakeError; 25 MakeError = from.MakeError;
27 MapEntries = from.MapEntries; 26 MapEntries = from.MapEntries;
28 MapIteratorNext = from.MapIteratorNext; 27 MapIteratorNext = from.MapIteratorNext;
29 SetIteratorNext = from.SetIteratorNext; 28 SetIteratorNext = from.SetIteratorNext;
30 SetValues = from.SetValues; 29 SetValues = from.SetValues;
31 SymbolToString = from.SymbolToString;
32 }); 30 });
33 31
34 // ---------------------------------------------------------------------------- 32 // ----------------------------------------------------------------------------
35 33
36 // Mirror hierarchy: 34 // Mirror hierarchy:
37 // - Mirror 35 // - Mirror
38 // - ValueMirror 36 // - ValueMirror
39 // - UndefinedMirror 37 // - UndefinedMirror
40 // - NullMirror 38 // - NullMirror
41 // - BooleanMirror 39 // - BooleanMirror
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 * @constructor 677 * @constructor
680 * @extends Mirror 678 * @extends Mirror
681 */ 679 */
682 function SymbolMirror(value) { 680 function SymbolMirror(value) {
683 %_Call(ValueMirror, this, MirrorType.SYMBOL_TYPE, value); 681 %_Call(ValueMirror, this, MirrorType.SYMBOL_TYPE, value);
684 } 682 }
685 inherits(SymbolMirror, ValueMirror); 683 inherits(SymbolMirror, ValueMirror);
686 684
687 685
688 SymbolMirror.prototype.description = function() { 686 SymbolMirror.prototype.description = function() {
689 return %SymbolDescription(%_ValueOf(this.value_)); 687 return %SymbolDescription(%ValueOf(this.value_));
690 } 688 }
691 689
692 690
693 SymbolMirror.prototype.toText = function() { 691 SymbolMirror.prototype.toText = function() {
694 return %_Call(SymbolToString, this.value_); 692 return %SymbolDescriptiveString(%ValueOf(this.value_));
695 } 693 }
696 694
697 695
698 /** 696 /**
699 * Mirror object for objects. 697 * Mirror object for objects.
700 * @param {object} value The object reflected by this mirror 698 * @param {object} value The object reflected by this mirror
701 * @param {boolean} transient indicate whether this object is transient with a 699 * @param {boolean} transient indicate whether this object is transient with a
702 * transient handle 700 * transient handle
703 * @constructor 701 * @constructor
704 * @extends ValueMirror 702 * @extends ValueMirror
(...skipping 2342 matching lines...) Expand 10 before | Expand all | Expand 10 after
3047 // Functions needed by the debugger runtime. 3045 // Functions needed by the debugger runtime.
3048 utils.InstallFunctions(utils, DONT_ENUM, [ 3046 utils.InstallFunctions(utils, DONT_ENUM, [
3049 "ClearMirrorCache", ClearMirrorCache 3047 "ClearMirrorCache", ClearMirrorCache
3050 ]); 3048 ]);
3051 3049
3052 // Export to debug.js 3050 // Export to debug.js
3053 utils.Export(function(to) { 3051 utils.Export(function(to) {
3054 to.MirrorType = MirrorType; 3052 to.MirrorType = MirrorType;
3055 }); 3053 });
3056 }) 3054 })
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698