Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2126453002: [intrinsic] Drop the %_ValueOf intrinsic. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsic] Drop the %_ValueOf intrinsic. This drops the %_ValueOf intrinsic, but keeps the runtime entry %ValueOf for now, by either migrating the functionality (mostly Debug mirror or toString/valueOf methods) to C++ or TurboFan builtins, or switching to the %ValueOf runtime call when it's not performance critical anyways. The %_ValueOf intrinsic was one of the last blockers for fixing the unsound machine operator typing in TurboFan. R=yangguo@chromium.org BUG=v8:5049 Committed: https://crrev.com/293bd7882987f00e465710ce468bfb1eaa7d3fa2 Committed: https://crrev.com/72275e662007163bd5afbae8f6771ddab1688882 Cr-Original-Commit-Position: refs/heads/master@{#37512} Cr-Commit-Position: refs/heads/master@{#37519}

Patch Set 1 #

Patch Set 2 : Nuke IS_NUMBER_WRAPPER #

Patch Set 3 : Fix noi18n build (narf) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+503 lines, -703 lines) Patch
M src/bootstrapper.cc View 1 2 4 chunks +57 lines, -2 lines 0 comments Download
M src/builtins.h View 1 2 7 chunks +32 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 2 6 chunks +315 lines, -35 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +75 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -66 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/debug/mirrors.js View 3 chunks +2 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/js/harmony-simd.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/macros.py View 1 4 chunks +0 lines, -9 lines 0 comments Download
M src/js/messages.js View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M src/js/prologue.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/string.js View 2 chunks +0 lines, -20 lines 0 comments Download
M src/js/symbol.js View 2 chunks +0 lines, -47 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +0 lines, -135 lines 0 comments Download
M src/runtime/runtime.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D test/mjsunit/compiler/regress-valueof.js View 1 chunk +0 lines, -35 lines 0 comments Download
M test/mjsunit/error-tostring-omit.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126453002/1
4 years, 5 months ago (2016-07-05 05:54:41 UTC) #2
Benedikt Meurer
4 years, 5 months ago (2016-07-05 05:54:47 UTC) #3
Benedikt Meurer
Hey Yang, Some cleanup on the intrinsics. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-05 05:55:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126453002/20001
4 years, 5 months ago (2016-07-05 06:22:39 UTC) #6
Yang
On 2016/07/05 06:22:39, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 5 months ago (2016-07-05 06:32:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126453002/20001
4 years, 5 months ago (2016-07-05 06:35:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 06:45:43 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 06:45:44 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/293bd7882987f00e465710ce468bfb1eaa7d3fa2 Cr-Commit-Position: refs/heads/master@{#37512}
4 years, 5 months ago (2016-07-05 06:48:03 UTC) #14
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2117273002/ by machenbach@chromium.org. ...
4 years, 5 months ago (2016-07-05 07:59:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126453002/40001
4 years, 5 months ago (2016-07-05 09:37:07 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_noi18n_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_noi18n_rel_ng/builds/12)
4 years, 5 months ago (2016-07-05 09:48:00 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126453002/40001
4 years, 5 months ago (2016-07-05 09:48:59 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-05 10:03:44 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 10:05:49 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/72275e662007163bd5afbae8f6771ddab1688882
Cr-Commit-Position: refs/heads/master@{#37519}

Powered by Google App Engine
This is Rietveld 408576698