Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2126443002: Rename DeviceInertialSensorService to DeviceSensorService. (Closed)

Created:
4 years, 5 months ago by Sam McNally
Modified:
4 years, 5 months ago
Reviewers:
no sievers, timvolodine
CC:
chromium-reviews, riju_, jam, timvolodine, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org, dcheng, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@conversion--sensors
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DeviceInertialSensorService to DeviceSensorService. DeviceInertialSensorService is used for light sensors so the name is no longer appropriate. Committed: https://crrev.com/63eb89012f229fba01bd0296e7d61d654f2d5e89 Cr-Commit-Position: refs/heads/master@{#406475}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -672 lines) Patch
M content/browser/browser_main_loop.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
D content/browser/device_sensors/device_inertial_sensor_browsertest.cc View 1 1 chunk +0 lines, -361 lines 0 comments Download
D content/browser/device_sensors/device_inertial_sensor_service.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/browser/device_sensors/device_inertial_sensor_service.cc View 1 chunk +0 lines, -117 lines 0 comments Download
A + content/browser/device_sensors/device_sensor_browsertest.cc View 1 13 chunks +45 lines, -58 lines 0 comments Download
M content/browser/device_sensors/device_sensor_host.cc View 4 chunks +5 lines, -6 lines 0 comments Download
A + content/browser/device_sensors/device_sensor_service.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + content/browser/device_sensors/device_sensor_service.cc View 8 chunks +18 lines, -22 lines 0 comments Download
M content/browser/device_sensors/device_sensors_consts.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
Sam McNally
4 years, 5 months ago (2016-07-08 06:18:29 UTC) #3
timvolodine
lgtm, thanks!
4 years, 5 months ago (2016-07-08 16:18:31 UTC) #5
Sam McNally
+sievers for content/browser/browser_main_loop.cc
4 years, 5 months ago (2016-07-11 03:54:55 UTC) #7
no sievers
On 2016/07/11 03:54:55, Sam McNally wrote: > +sievers for content/browser/browser_main_loop.cc sorry, missed this. lgtm stamp
4 years, 5 months ago (2016-07-18 22:35:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126443002/40001
4 years, 5 months ago (2016-07-20 03:02:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-20 03:07:32 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 03:07:44 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 03:08:57 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63eb89012f229fba01bd0296e7d61d654f2d5e89
Cr-Commit-Position: refs/heads/master@{#406475}

Powered by Google App Engine
This is Rietveld 408576698