ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc - Issue 2126433002: Use container::back() and container::pop_back() in ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc

Issue 2126433002: Use container::back() and container::pop_back() in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/ozone/evdev/libgestures_glue/gesture_logging.cc ('k') | ui/message_center/notification_list_unittest.cc » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc

diff --git a/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc b/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc

index cde379153b64eb4c48f5599d39809f0ec5588cbb..c12564c41f8169f89289117a70610203079dc41c 100644

--- a/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc

+++ b/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc

@@ -1078,8 +1078,7 @@ void GesturePropertyProvider::ParseXorgConfFile(const std::string& content) {

// one.

if (is_parsing) {

// Stop parsing the current line if the format is wrong.

- if (piece.size() <= 2 || piece[0] != '\"' ||

- piece[piece.size() - 1] != '\"') {

+ if (piece.size() <= 2 || piece[0] != '\"' || piece.back() != '\"') {

LOG(ERROR) << "Error parsing line: " << lines.token();

has_error = true;

if (next_is_section_type)