ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc - Issue 2126433002: Use container::back() and container::pop_back() in ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

Issue 2126433002: Use container::back() and container::pop_back() in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/display/mac/screen_mac.mm ('k') | ui/events/ozone/evdev/libgestures_glue/gesture_logging.cc » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

diff --git a/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc b/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

index 65388a2e7589b01b88ba1db503353d8c161c4146..b1d46cef76b7db63c06f45f38cea64376e7df924 100644

--- a/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

+++ b/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

@@ -20,8 +20,8 @@ namespace {

std::string FormatLog(const char* fmt, va_list args) {

std::string msg = base::StringPrintV(fmt, args);

- if (!msg.empty() && msg[msg.size() - 1] == '\n')

- msg.erase(msg.end() - 1, msg.end());

+ if (!msg.empty() && msg.back() == '\n')

+ msg.pop_back();

return msg;

}