ui/base/win/open_file_name_win_unittest.cc - Issue 2126433002: Use container::back() and container::pop_back() in ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/win/open_file_name_win_unittest.cc

Issue 2126433002: Use container::back() and container::pop_back() in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/win/open_file_name_win_unittest.cc

diff --git a/ui/base/win/open_file_name_win_unittest.cc b/ui/base/win/open_file_name_win_unittest.cc

index bce8abcfa729495462a5fb67ab49c06f73e6264f..a6e6ff1f8fbd92d9d5f5e072a2c4458ef071d8fc 100644

--- a/ui/base/win/open_file_name_win_unittest.cc

+++ b/ui/base/win/open_file_name_win_unittest.cc

@@ -19,7 +19,7 @@ void SetResult(const base::string16& result, ui::win::OpenFileName* ofn) {

ADD_FAILURE() << "filename buffer insufficient.";

return;

}

- if (!result.size()) {

+ if (result.empty()) {

ofn->GetOPENFILENAME()->lpstrFile[0] = 0;

} else {

// Because the result has embedded nulls, we must memcpy.

« no previous file with comments | « ui/base/ime/win/imm32_manager.cc ('k') | ui/compositor/layer_animator_collection.cc » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')