Issue 212643016: Fix deopts causing uninitialized fixed typed arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212643016: Fix deopts causing uninitialized fixed typed arrays. (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix deopts causing uninitialized fixed typed arrays. The deopt will not happen in production code, since we check that lengths of fixed typed arrays are smis before calling TypedArrayInitialze, but that makes deopt bot happy. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20324

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	src/hydrogen.cc	View		6 chunks	+10 lines, -5 lines	0 comments	Download
	M	src/runtime.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

6 years, 9 months ago (2014-03-28 08:59:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20324 (presubmit successful).

Expand Messages | Collapse Messages