Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 212643013: Use default SkCanvas::save() flags. (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Use default SkCanvas::save() flags. This CL removes explicit SkCanvas::SaveFlags from Blink: they are being deprecated in Skia, and we are only passing defaults anyway. R=schenney@chromium.org, reed@google.com, senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170189

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 3 chunks +8 lines, -10 lines 1 comment Download
M Source/platform/graphics/GraphicsContext.cpp View 16 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
f(malita)
6 years, 9 months ago (2014-03-27 14:00:49 UTC) #1
Stephen Chennney
lgtm https://codereview.chromium.org/212643013/diff/1/Source/platform/graphics/GraphicsContext.h File Source/platform/graphics/GraphicsContext.h (right): https://codereview.chromium.org/212643013/diff/1/Source/platform/graphics/GraphicsContext.h#newcode481 Source/platform/graphics/GraphicsContext.h:481: bool m_pendingCanvasSave; Maybe in a follow up, move ...
6 years, 9 months ago (2014-03-27 14:15:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/212643013/1
6 years, 9 months ago (2014-03-27 14:15:48 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:31:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 14:31:23 UTC) #5
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-27 14:33:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/212643013/1
6 years, 9 months ago (2014-03-27 14:33:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:43:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 14:43:46 UTC) #9
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-27 14:52:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/212643013/1
6 years, 9 months ago (2014-03-27 14:52:26 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:02:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 15:02:31 UTC) #13
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-27 15:22:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/212643013/1
6 years, 9 months ago (2014-03-27 15:22:21 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:32:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 15:32:37 UTC) #17
f(malita)
6 years, 9 months ago (2014-03-27 15:45:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 manually as r170189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698