Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 212643002: Use [StrictTypeChecking] for HTMLMediaElement.setMediaKeys (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 8 months ago
Reviewers:
ddorwin
CC:
blink-reviews, feature-media-reviews_chromium.org, eric.carlson_apple.com, Nils Barth (inactive)
Visibility:
Public.

Description

Use [StrictTypeChecking] for HTMLMediaElement.setMediaKeys The mediaKeys argument should be nullable, but passing in some other type of object should throw an exception. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170354

Patch Set 1 #

Patch Set 2 : nullable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/media/encrypted-media/encrypted-media-setmediakeys.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
David, PTAL. I had this sitting half-finished from when this was part of HTMLMediaElement, since ...
6 years, 9 months ago (2014-03-26 10:55:27 UTC) #1
ddorwin
On 2014/03/26 10:55:27, philipj wrote: > David, PTAL. I had this sitting half-finished from when ...
6 years, 9 months ago (2014-03-26 17:45:32 UTC) #2
philipj_slow
On 2014/03/26 17:45:32, ddorwin wrote: > On 2014/03/26 10:55:27, philipj wrote: > > David, PTAL. ...
6 years, 9 months ago (2014-03-26 17:54:03 UTC) #3
ddorwin
On 2014/03/26 17:54:03, philipj wrote: > On 2014/03/26 17:45:32, ddorwin wrote: > > On 2014/03/26 ...
6 years, 9 months ago (2014-03-26 18:08:34 UTC) #4
philipj_slow
On 2014/03/26 18:08:34, ddorwin wrote: > On 2014/03/26 17:54:03, philipj wrote: > > On 2014/03/26 ...
6 years, 9 months ago (2014-03-26 18:17:20 UTC) #5
philipj_slow
Ping ddorwin. Adding StrictTypeChecking does result in an observable change, so I updated the test ...
6 years, 8 months ago (2014-03-28 09:29:32 UTC) #6
ddorwin
LGTM. Thanks. I didn't know you had uploaded a new PS.
6 years, 8 months ago (2014-03-28 18:47:20 UTC) #7
philipj_slow
On 2014/03/28 18:47:20, ddorwin wrote: > LGTM. Thanks. I didn't know you had uploaded a ...
6 years, 8 months ago (2014-03-28 19:16:38 UTC) #8
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-03-28 19:16:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/212643002/60001
6 years, 8 months ago (2014-03-28 19:16:53 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 19:28:48 UTC) #11
Message was sent while issue was closed.
Change committed as 170354

Powered by Google App Engine
This is Rietveld 408576698