Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2126413002: Allow for recursive invocation of SafepointOperationScopes. (Closed)

Created:
4 years, 5 months ago by siva
Modified:
4 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow for recursive invocation of SafepointOperationScopes. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/56fba25f0fc96d2c32cfed563ed32db354a2d4b9

Patch Set 1 #

Patch Set 2 : Address self review comments. #

Total comments: 4

Patch Set 3 : Address code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -17 lines) Patch
M runtime/vm/isolate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/safepoint.h View 1 2 2 chunks +39 lines, -9 lines 0 comments Download
M runtime/vm/safepoint.cc View 1 4 chunks +24 lines, -7 lines 0 comments Download
M runtime/vm/thread_test.cc View 2 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 5 months ago (2016-07-07 21:43:33 UTC) #2
Florian Schneider
Lgtm. https://codereview.chromium.org/2126413002/diff/20001/runtime/vm/safepoint.h File runtime/vm/safepoint.h (right): https://codereview.chromium.org/2126413002/diff/20001/runtime/vm/safepoint.h#newcode51 runtime/vm/safepoint.h:51: ASSERT(safepoint_operation_count_== 0); formatting: spaces around ==. https://codereview.chromium.org/2126413002/diff/20001/runtime/vm/safepoint.h#newcode58 runtime/vm/safepoint.h:58: ...
4 years, 5 months ago (2016-07-07 22:00:20 UTC) #3
siva
Committed patchset #3 (id:40001) manually as 56fba25f0fc96d2c32cfed563ed32db354a2d4b9 (presubmit successful).
4 years, 5 months ago (2016-07-07 22:27:53 UTC) #5
siva
4 years, 4 months ago (2016-08-23 18:03:12 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2126413002/diff/20001/runtime/vm/safepoint.h
File runtime/vm/safepoint.h (right):

https://codereview.chromium.org/2126413002/diff/20001/runtime/vm/safepoint.h#...
runtime/vm/safepoint.h:51: ASSERT(safepoint_operation_count_== 0);
On 2016/07/07 22:00:19, Florian Schneider wrote:
> formatting: spaces around ==.

Done.

https://codereview.chromium.org/2126413002/diff/20001/runtime/vm/safepoint.h#...
runtime/vm/safepoint.h:58: ASSERT(safepoint_operation_count_== 1);
On 2016/07/07 22:00:19, Florian Schneider wrote:
> formatting: spaces around ==.

Done.

Powered by Google App Engine
This is Rietveld 408576698