Cache compile-time constants on the script object, sometimes.

Cache compile-time constants on the script object, sometimes.

When a script is not in the vm heap, we now cache compile time
constants on the script object itself.  During isolate reload we may
have both an old and a new version of a script being compiled at the
same time and they need to cache their constants separately.  This
also means that compile time constants from old scripts can be
collected when the script is collected, which is good.

When a script is in the vm heap, we continue to use the old system of
employing a shared per-isolate cache stored in the object store.

Closes #26833

BUG=
R=fschneider@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/62ccff992fc64403d5d4693ee4ca1b71e02df360

[turnidge, 2016-07-08 00:17:55]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-07-08 01:06:25]

LGTM with a small nit.

Nice cleanup of the whole system!

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/isolate_relo...
File runtime/vm/isolate_reload.h (right):

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.h:115: void BuildCleanScriptSet();
BuildCleanScriptSet can go now too (I think)

[Florian Schneider, 2016-07-08 18:01:25]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-07-08 18:01:25]

Lgtm.

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:107: // Used by CachConstantValue if a new constant is added
to the map.
s/CachConstantValue/CacheConstantValue/

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:143: // Used by CachConstantValue if a new constant is added
to the map.
s/CachConstantValue/CacheConstantValue/

[turnidge, 2016-07-11 21:00:43]

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/isolate_relo...
File runtime/vm/isolate_reload.h (right):

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.h:115: void BuildCleanScriptSet();
On 2016/07/08 01:06:25, Cutch wrote:
> BuildCleanScriptSet can go now too (I think)

Done.

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:107: // Used by CachConstantValue if a new constant is added
to the map.
On 2016/07/08 18:01:25, Florian Schneider wrote:
> s/CachConstantValue/CacheConstantValue/

Done.

https://codereview.chromium.org/2126393003/diff/20001/runtime/vm/parser.h#new...
runtime/vm/parser.h:143: // Used by CachConstantValue if a new constant is added
to the map.
On 2016/07/08 18:01:25, Florian Schneider wrote:
> s/CachConstantValue/CacheConstantValue/

Done.

[turnidge, 2016-07-11 21:15:34]

Description was changed from

==========
Cache compile-time constants on the script object, sometimes.

When a script is not in the vm heap, we now cache compile time
constants on the script object itself.  During isolate reload we may
have both an old and a new version of a script being compiled at the
same time and they need to cache their constants separately.  This
also means that compile time constants from old scripts can be
collected when the script is collected, which is good.

When a script is in the vm heap, we continue to use the old system of
employing a shared per-isolate cache stored in the object store.

Closes #26833

BUG=
==========

to

==========
Cache compile-time constants on the script object, sometimes.

When a script is not in the vm heap, we now cache compile time
constants on the script object itself.  During isolate reload we may
have both an old and a new version of a script being compiled at the
same time and they need to cache their constants separately.  This
also means that compile time constants from old scripts can be
collected when the script is collected, which is good.

When a script is in the vm heap, we continue to use the old system of
employing a shared per-isolate cache stored in the object store.

Closes #26833

BUG=
R=fschneider@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/62ccff992fc64403d5d4693ee4ca1b71e02df360
==========

[turnidge, 2016-07-11 21:15:35]

Committed patchset #3 (id:40001) manually as
62ccff992fc64403d5d4693ee4ca1b71e02df360 (presubmit successful).