chrome/browser/password_manager/account_chooser_dialog_android.h - Issue 2126353003: [CM API] Account Chooser with Sign in button for single account

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.h

Issue 2126353003: [CM API] Account Chooser with Sign in button for single account (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unnssary checks Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java ('k') | chrome/browser/password_manager/account_chooser_dialog_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/account_chooser_dialog_android.h

diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.h b/chrome/browser/password_manager/account_chooser_dialog_android.h

index 139591ff98dbfcf2939f4a3efae1afeecc1a09a6..7326976d8962a54421bd5ff0f64366c4eb7e91f2 100644

--- a/chrome/browser/password_manager/account_chooser_dialog_android.h

+++ b/chrome/browser/password_manager/account_chooser_dialog_android.h

@@ -47,7 +47,8 @@ class AccountChooserDialogAndroid : public content::WebContentsObserver {

void OnCredentialClicked(JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

jint credential_item,

- jint credential_type);

+ jint credential_type,

+ jboolean sign_button_clicked);

// Opens new tab with page which explains the Smart Lock branding.

void OnLinkClicked(JNIEnv* env,

@@ -66,7 +67,9 @@ class AccountChooserDialogAndroid : public content::WebContentsObserver {

const std::vector<const autofill::PasswordForm*>&

federated_credentials_forms() const;

- void ChooseCredential(size_t index, password_manager::CredentialType type);

+ void ChooseCredential(size_t index,

+ password_manager::CredentialType type,

+ bool sign_button_clicked);

content::WebContents* web_contents_;

ManagePasswordsState passwords_data_;