Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2126353002:
Added deobfuscation script for ProGuarded stacktraces (Closed)
|
Created:
4 years, 5 months ago by smaier Modified:
4 years, 5 months ago Reviewers:
agrieve CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded deobfuscation script for ProGuarded stacktraces
BUG=625704
Committed: https://crrev.com/1a09539d6fb37c06bc73ce348f6f7ea85ddacfa4
Cr-Commit-Position: refs/heads/master@{#404476}
Patch Set 1 #
Total comments: 12
Patch Set 2 : Moving script into its own folder #Patch Set 3 : Addressing comments #Messages
Total messages: 19 (9 generated)
smaier@chromium.org changed reviewers: + agrieve@chromium.org
On 2016/07/07 19:36:03, smaier wrote: nit from cc list: would strongly prefer this in a subdirectory of build/android/ than in build/android/ itself.
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
John - this is the directory where tombstones.py and asan_symbolize.py live. What would be a better spot? https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... File build/android/java_deobfuscate.py (right): https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:5: # A tool to deobfuscate java stack traces nit: change this to pydoc: """A tool to deobfuscate Java stack traces. ... description from ArgumentParser ... """ https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:22: LINE_PARSE_REGEX = ( nit: prefix with _ https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:24: nit: here and below - 2 blank lines between top-level functions. https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:25: def _IterProcessStdout(process, timeout=None, buffer_size=4096, Probably it'd be nicer to depend on the version in catapult rather than copy & paste. You can sneakily do this via: import pylib # Allows devil to be imported from devil.utils import cmd_helper https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:70: description=('Utility wrapper around ReTrace to deobfuscate stack traces ' move this to file's docstring and use: description=__doc__ https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:88: if args.stacktrace is not None: nit: drop the "is not None" part
On 2016/07/08 14:40:14, agrieve wrote: > John - this is the directory where tombstones.py and asan_symbolize.py live. > What would be a better spot? Those are more for legacy reasons at this point. Ideally, they'd' be in a subdirectory as well, potentially w/ this. (//build/android/symbolize?) > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > File build/android/java_deobfuscate.py (right): > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:5: # A tool to deobfuscate java stack traces > nit: change this to pydoc: > > """A tool to deobfuscate Java stack traces. > > ... description from ArgumentParser ... > """ > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:22: LINE_PARSE_REGEX = ( > nit: prefix with _ > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:24: > nit: here and below - 2 blank lines between top-level functions. > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:25: def _IterProcessStdout(process, > timeout=None, buffer_size=4096, > Probably it'd be nicer to depend on the version in catapult rather than copy & > paste. > > You can sneakily do this via: > import pylib # Allows devil to be imported > from devil.utils import cmd_helper > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:70: description=('Utility wrapper around > ReTrace to deobfuscate stack traces ' > move this to file's docstring and use: description=__doc__ > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:88: if args.stacktrace is not None: > nit: drop the "is not None" part
https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... File build/android/java_deobfuscate.py (right): https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:5: # A tool to deobfuscate java stack traces On 2016/07/08 14:40:13, agrieve wrote: > nit: change this to pydoc: > > """A tool to deobfuscate Java stack traces. > > ... description from ArgumentParser ... > """ Done. https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:22: LINE_PARSE_REGEX = ( On 2016/07/08 14:40:13, agrieve wrote: > nit: prefix with _ Done. https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:24: On 2016/07/08 14:40:14, agrieve wrote: > nit: here and below - 2 blank lines between top-level functions. Done. https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:25: def _IterProcessStdout(process, timeout=None, buffer_size=4096, On 2016/07/08 14:40:14, agrieve wrote: > Probably it'd be nicer to depend on the version in catapult rather than copy & > paste. > > You can sneakily do this via: > import pylib # Allows devil to be imported > from devil.utils import cmd_helper Done. https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:70: description=('Utility wrapper around ReTrace to deobfuscate stack traces ' On 2016/07/08 14:40:13, agrieve wrote: > move this to file's docstring and use: description=__doc__ Done. https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... build/android/java_deobfuscate.py:88: if args.stacktrace is not None: On 2016/07/08 14:40:13, agrieve wrote: > nit: drop the "is not None" part Done.
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/08 16:00:31, smaier wrote: > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > File build/android/java_deobfuscate.py (right): > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:5: # A tool to deobfuscate java stack traces > On 2016/07/08 14:40:13, agrieve wrote: > > nit: change this to pydoc: > > > > """A tool to deobfuscate Java stack traces. > > > > ... description from ArgumentParser ... > > """ > > Done. > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:22: LINE_PARSE_REGEX = ( > On 2016/07/08 14:40:13, agrieve wrote: > > nit: prefix with _ > > Done. > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:24: > On 2016/07/08 14:40:14, agrieve wrote: > > nit: here and below - 2 blank lines between top-level functions. > > Done. > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:25: def _IterProcessStdout(process, > timeout=None, buffer_size=4096, > On 2016/07/08 14:40:14, agrieve wrote: > > Probably it'd be nicer to depend on the version in catapult rather than copy & > > paste. > > > > You can sneakily do this via: > > import pylib # Allows devil to be imported > > from devil.utils import cmd_helper > > Done. > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:70: description=('Utility wrapper around > ReTrace to deobfuscate stack traces ' > On 2016/07/08 14:40:13, agrieve wrote: > > move this to file's docstring and use: description=__doc__ > > Done. > > https://codereview.chromium.org/2126353002/diff/1/build/android/java_deobfusc... > build/android/java_deobfuscate.py:88: if args.stacktrace is not None: > On 2016/07/08 14:40:13, agrieve wrote: > > nit: drop the "is not None" part > > Done. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by smaier@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Added deobfuscation script for ProGuarded stacktraces BUG=625704 ========== to ========== Added deobfuscation script for ProGuarded stacktraces BUG=625704 Committed: https://crrev.com/1a09539d6fb37c06bc73ce348f6f7ea85ddacfa4 Cr-Commit-Position: refs/heads/master@{#404476} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1a09539d6fb37c06bc73ce348f6f7ea85ddacfa4 Cr-Commit-Position: refs/heads/master@{#404476} |
