Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 21263002: Add back captureEvents and releaseEvents (Closed)

Created:
7 years, 4 months ago by arv (Not doing code reviews)
Modified:
7 years, 4 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use
Visibility:
Public.

Description

Add back captureEvents and releaseEvents The main reason for adding this back is that it breaks a bunch of web sites. Another data point is that IE11 added it. This reverts commit 4c3ee987eadbaef48c3e514908d94cad9a0f8c1b. This also adds deprecatation warnings when calling these methods. BUG=238243 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155172

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -110 lines) Patch
A LayoutTests/fast/dom/HTMLDocument/capture-events.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLDocument/capture-events-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLDocument/release-events.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLDocument/release-events-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/capture-events.html View 1 chunk +11 lines, -0 lines 1 comment Download
A LayoutTests/fast/dom/Window/capture-events-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties.html View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/release-events.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/release-events-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/WindowProperties.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/resources/wrapper-identity-base.js View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-identity-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/global-function-resolve-expected.txt View 1 chunk +114 lines, -110 lines 0 comments Download
M LayoutTests/fast/js/script-tests/global-function-resolve.js View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get.html View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put.html View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 4 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/page/DOMWindow.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/page/Window.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
If this cannot be merged into M29 I will abandon this CL>
7 years, 4 months ago (2013-07-30 16:28:41 UTC) #1
arv (Not doing code reviews)
https://codereview.chromium.org/21263002/diff/1/LayoutTests/fast/dom/Window/capture-events.html File LayoutTests/fast/dom/Window/capture-events.html (right): https://codereview.chromium.org/21263002/diff/1/LayoutTests/fast/dom/Window/capture-events.html#newcode8 LayoutTests/fast/dom/Window/capture-events.html:8: window.captureEvents(); This does not cause a deprecation warning. I ...
7 years, 4 months ago (2013-07-30 18:09:15 UTC) #2
eseidel
lgtm Sigh.
7 years, 4 months ago (2013-07-30 19:16:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/21263002/1
7 years, 4 months ago (2013-07-30 19:33:25 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/page/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-07-30 19:33:48 UTC) #5
arv (Not doing code reviews)
7 years, 4 months ago (2013-07-30 19:40:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r155172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698