Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2126273002: Let components/ntp_snippets/ owners also own chrome/browser/ntp_snippets/ (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let components/ntp_snippets/ owners also own chrome/browser/ntp_snippets/ Committed: https://crrev.com/88f0912daa629d9f0f68b5b0b67c42e3f2fabc7a Cr-Commit-Position: refs/heads/master@{#404176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ntp_snippets/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Marc Treib
4 years, 5 months ago (2016-07-07 15:17:00 UTC) #1
Marc Treib
4 years, 5 months ago (2016-07-07 15:17:11 UTC) #3
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-07 16:06:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126273002/1
4 years, 5 months ago (2016-07-07 16:11:59 UTC) #6
markusheintz_
On 2016/07/07 16:11:59, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-07 16:12:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 17:48:48 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 17:49:03 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 17:50:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88f0912daa629d9f0f68b5b0b67c42e3f2fabc7a
Cr-Commit-Position: refs/heads/master@{#404176}

Powered by Google App Engine
This is Rietveld 408576698