Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212623013: DevTools: Make SourcesView shortcut work when it's shown in drawer and move "save" shortcut into it (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
apavlov, lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Make SourcesView shortcut work when it is shown in drawer and move "save" shortcut into it. R=pfeldman@chromium.org, apavlov, lushnikov, pfeldman BUG=322632, 349428 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170309

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -13 lines) Patch
M Source/devtools/front_end/ShortcutsScreen.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/SourcesView.js View 3 chunks +54 lines, -6 lines 0 comments Download
M Source/devtools/front_end/UISourceCodeFrame.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-27 16:04:15 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-27 16:43:22 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-28 08:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212623013/20001
6 years, 9 months ago (2014-03-28 08:29:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 08:39:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 08:39:18 UTC) #6
vsevik
6 years, 9 months ago (2014-03-28 10:07:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r170309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698