Add GOMA_DIR to the set of searched paths, and default it to something sensible (.)

Add GOMA_DIR to the set of searched paths, and default it to something sensible (.)

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260185

[johnme, 2014-03-27 15:15:30]

Thanks Ian! LGTM with optional nit.

https://codereview.chromium.org/212623012/diff/1/tools/cr/cr/actions/ninja.py
File tools/cr/cr/actions/ninja.py (right):

https://codereview.chromium.org/212623012/diff/1/tools/cr/cr/actions/ninja.py...
tools/cr/cr/actions/ninja.py:16: GOMA_DIR=os.path.join('.', 'goma'),
It seems a bit brittle to be searching the current directory for goma.
Can we make this line be:

    GOMA_DIR=os.path.expanduser('~/goma'),

instead (and perhaps remove that below to avoid duplication)?

[ian_cottrell, 2014-03-27 15:27:04]

On 2014/03/27 15:15:30, johnme wrote:
> Thanks Ian! LGTM with optional nit.
> 
> https://codereview.chromium.org/212623012/diff/1/tools/cr/cr/actions/ninja.py
> File tools/cr/cr/actions/ninja.py (right):
> 
>
https://codereview.chromium.org/212623012/diff/1/tools/cr/cr/actions/ninja.py...
> tools/cr/cr/actions/ninja.py:16: GOMA_DIR=os.path.join('.', 'goma'),
> It seems a bit brittle to be searching the current directory for goma.
> Can we make this line be:
> 
>     GOMA_DIR=os.path.expanduser('~/goma'),
> 
> instead (and perhaps remove that below to avoid duplication)?

Change it to do the user dir by default, but the one below is not redundant, if
you set your GOMA_DIR to something wrong but have goma in your homedir, we
should still pick it up. This is meant to be a forgiving tool.

[johnme, 2014-03-27 16:03:11]

lgtm

[ian_cottrell, 2014-03-27 16:08:52]

The CQ bit was checked by iancottrell@chromium.org

[commit-bot: I haz the power, 2014-03-27 16:09:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/212623012/20001

[commit-bot: I haz the power, 2014-03-27 16:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 16:14:52]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[ian_cottrell, 2014-03-28 11:22:21]

The CQ bit was checked by iancottrell@chromium.org

[commit-bot: I haz the power, 2014-03-28 11:24:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/212623012/20001

[commit-bot: I haz the power, 2014-03-28 17:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 17:00:20]

Retried try job too often on ios_dbg_simulator for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[ian_cottrell, 2014-03-28 17:19:10]

The CQ bit was checked by iancottrell@chromium.org

[commit-bot: I haz the power, 2014-03-28 17:22:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/212623012/20001

[commit-bot: I haz the power, 2014-03-28 17:25:52]

Change committed as 260185