Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: icu52/README.chromium

Issue 212623010: ICU 52 : update gyp and isolate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/
Patch Set: configure.patch added Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | icu52/icu.gyp » ('j') | icu52/icu.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu52/README.chromium
===================================================================
--- icu52/README.chromium (revision 259826)
+++ icu52/README.chromium (working copy)
@@ -18,47 +18,17 @@
- source/layout
- source/layoutex
-2. Platform header files for Linux, FreeBSD, OpenBSD, Android, Mac OS X, and QNX:
+ patches/configure.patch is applied to get runConfigureICU work in the
+ icudata generation step without layout and layoutex directory by removing the
+ corresponding Makefile's from ac_config variable.
- - Apply platform.patch in patches directory. : It applies the upstream
- patch to platform.h.in (see http://bugs.icu-project.org/trac/ticket/8248)
- and change source/common/unicode/ptypes.h to refer to plinux.h and
- pmac.h generated below.
+2. Apply the following patch for platform related headers (putilimpl.h and
+ others).
- - 'runConfigureICU Linux', 'runConfigureICU FreeBSD', and
- 'runConfigureICU MacOSX' are run to generate
- source/common/unicode/platform.h.
+ - patches/platform.patch for Android and QNX
+ Upstream bug for Android : http://bugs.icu-project.org/trac/ticket/10478
- - On OpenBSD, source/common/unicode/platform.h is being generated
- by the icu4c port in the ports directory and not by runConfigureICU.
- In case the file has to be updated you can do:
- cd /home/ports/textproc/icu4c && make configure
- - Rename it to 'plinux.h', 'pfreebsd.h', 'popenbsd.h' and 'pmac.h'
-
- - Apply patches/pmach.h.patch on Mac to pmac.h
-
- - On Android, the pandroid.h was generated by copying plinux.h to
- pandroid.h and applying the patches/pandroid.h.patch.
-
- - For QNX, the pqnx.h was generated by copying plinux.h to
- pqnx.h and applying the patches/platform.qnx.patch.
-
- - For NaCl (icu_nacl.gypi), the pnacl.h was generated by copying plinux.h to
- pnacl.h and applying the patches/pnacl.h.patch.
-
- - Apply the CL at https://codereview.chromium.org/15973007/ to plinux.h
-
-3. The following directories were removed because they're not used by Chromium
- at the moment:
- as_is
- packaging
- source/extra
- source/sample
- source/layout
- source/layoutex
-
-
4. The word breaking for Chinese and Japanese were modified to use a word
frequency list with the following patch and cjdict.txt.
@@ -314,14 +284,3 @@
27. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT.
- patches/declspec.patch
-
-28. Add support for QNX Neutrino.
- - patches/platform.qnx.patch:
- See #2 about the platform header generation.
- - patches/si_value.undef.patch:
- Work around an all-lowercase macro defined in <signal.h>.
- Upstream took a different approach:
- http://bugs.icu-project.org/trac/ticket/9935
- - patches/xopen_source.patch:
- Set _XOPEN_SOURCE to 600 as in the upstream changeset:
- http://bugs.icu-project.org/trac/changeset/30418
« no previous file with comments | « no previous file | icu52/icu.gyp » ('j') | icu52/icu.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698