Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 212623002: Merged r20033, r20138 into 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Michael Starzinger
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Merged r20033, r20138 into 3.24 branch. Fix TransitionElementsKindStub to handle non-JSArray objects correctly. Fix missing access check in Runtime_SetPrototype. BUG=352982, chromium:354123 R=ulan@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -22 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.h View 3 chunks +9 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-352982.js View 1 chunk +21 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 9 months ago (2014-03-26 10:19:30 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-26 10:31:13 UTC) #2
Michael Starzinger
6 years, 9 months ago (2014-03-26 10:32:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20269.

Powered by Google App Engine
This is Rietveld 408576698