Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2126203002: Send setting for enabling Android backup to container. (Closed)

Created:
4 years, 5 months ago by vkuzkokov
Modified:
4 years, 5 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send setting for enabling Android backup to container. BUG=627109 Committed: https://crrev.com/5fe9eeb3e2cab79085daca98bab26a93793ad546 Cr-Commit-Position: refs/heads/master@{#405972}

Patch Set 1 #

Patch Set 2 : Pass whether the setting is enforced by policy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/chromeos/arc/arc_settings_service.cc View 1 4 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
vkuzkokov
PTAL
4 years, 5 months ago (2016-07-07 12:57:07 UTC) #2
Yusuke Sato
lgtm w/ one nit: Can you file a placeholder crbug.com bug and use the bug# ...
4 years, 5 months ago (2016-07-11 02:52:15 UTC) #3
vkuzkokov
Added crbug. Also added "managed" extra that would notify container that it should disable toggle ...
4 years, 5 months ago (2016-07-13 17:54:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126203002/20001
4 years, 5 months ago (2016-07-18 09:58:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 10:32:25 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 10:34:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fe9eeb3e2cab79085daca98bab26a93793ad546
Cr-Commit-Position: refs/heads/master@{#405972}

Powered by Google App Engine
This is Rietveld 408576698