Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 21262003: Remove String::adopt(Vector<UChar>) (Closed)

Created:
7 years, 4 months ago by abarth-chromium
Modified:
7 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Remove String::adopt(Vector<UChar>) Adopting a Vector<UChar> isn't an efficient way to build a string. There are only two callers, so we should remove this API before we grow more. I've moved the callers over to StringBuilder and StringBuffer. There was one caller in EventSource that I moved to copying the characters rather than adopting them. R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155225

Patch Set 1 #

Patch Set 2 : Remove them all #

Patch Set 3 : Fix win #

Patch Set 4 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -158 lines) Patch
M Source/bindings/v8/SerializedScriptValue.cpp View 1 11 chunks +12 lines, -11 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +15 lines, -9 lines 0 comments Download
M Source/core/page/EventSource.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/platform/text/win/LocaleWin.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M Source/wtf/text/StringBuffer.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M Source/wtf/text/StringImpl.h View 1 2 11 chunks +13 lines, -115 lines 0 comments Download
M Source/wtf/text/StringImpl.cpp View 1 2 3 chunks +2 lines, -14 lines 0 comments Download
M Source/wtf/text/WTFString.h View 1 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
abarth-chromium
7 years, 4 months ago (2013-07-30 19:18:34 UTC) #1
eseidel
lgtm
7 years, 4 months ago (2013-07-30 19:40:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/21262003/1
7 years, 4 months ago (2013-07-30 19:47:42 UTC) #3
abarth-chromium
7 years, 4 months ago (2013-07-30 20:37:16 UTC) #4
eseidel
lgtm
7 years, 4 months ago (2013-07-30 20:40:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/21262003/11001
7 years, 4 months ago (2013-07-30 20:43:30 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-07-31 02:11:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/21262003/26001
7 years, 4 months ago (2013-07-31 02:26:49 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-07-31 03:53:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/21262003/38001
7 years, 4 months ago (2013-07-31 04:01:15 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 05:58:12 UTC) #11
Message was sent while issue was closed.
Change committed as 155225

Powered by Google App Engine
This is Rietveld 408576698